Fixed unit-test/sc_loads_tests.c for the address-sanitizer#147
Open
myc-yang wants to merge 1 commit intonasa:draco-rc5-evalfrom
Open
Fixed unit-test/sc_loads_tests.c for the address-sanitizer#147myc-yang wants to merge 1 commit intonasa:draco-rc5-evalfrom
myc-yang wants to merge 1 commit intonasa:draco-rc5-evalfrom
Conversation
19c7118 to
72410bd
Compare
dzbaker
reviewed
Jun 5, 2025
| SC_AtsEntryHeader_t *Entry; | ||
| SC_AtsInfoTable_t AtsInfoTbl; | ||
| uint32 AtsTable[SC_ATS_BUFF_SIZE32]; | ||
| uint32 Big_AtsTable[SC_ATS_BUFF_SIZE32 * 2]; |
Contributor
There was a problem hiding this comment.
What is the rationale for doubling the table size?
Author
There was a problem hiding this comment.
I don't think there was a specific rationale for doubling it. I just wanted to make sure it was big enough to prevent an overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on