Skip to content

Fixed unit-test/hk_utils_tests.c for the address-sanitizer#72

Open
myc-yang wants to merge 2 commits intonasa:mainfrom
myc-yang:fix-hk-unit-test-for-address-sanitizer
Open

Fixed unit-test/hk_utils_tests.c for the address-sanitizer#72
myc-yang wants to merge 2 commits intonasa:mainfrom
myc-yang:fix-hk-unit-test-for-address-sanitizer

Conversation

@myc-yang
Copy link

@myc-yang myc-yang commented Jun 2, 2025

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Steps taken to test the contribution:

  1. Unit tests passed with address sanitizer enabled

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • Unit tests will now pass when address-sanitizer is enabled

System(s) tested on

  • OS: Ubuntu 20.04.6

@myc-yang myc-yang marked this pull request as ready for review June 2, 2025 14:54
@myc-yang myc-yang force-pushed the fix-hk-unit-test-for-address-sanitizer branch from 3fb2291 to e045dbb Compare June 2, 2025 15:42
…IncomingHkData_LengthOkEqual(void) and Test_HK_ProcessIncomingHkData_LengthOkGreater(void)
Copy link
Contributor

@dzbaker dzbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 5 June 2025: Recommendation to make union containing buffer_t, adding space after with uint8[] (providing rationale for length of array). This will eliminate the need for casting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address sanitizer flagged stack buffer overflows in hk_utils_tests.c

2 participants