Merged
Conversation
includes tests and examples
And move pairwise_correlation
new comparison example
bug fixes, doc string
but fix
Improved plots, stats
Co-authored-by: Gavin Mischler <gavinmischler@gmail.com>
Bug fix on coef()
Collaborator
gavinmischler
left a comment
gavinmischler
left a comment
There was a problem hiding this comment.
Sorry, last things I didn't realize before, otherwise I think it's ready!
vinaysraghavan
commented
Mar 2, 2026
vinaysraghavan
commented
Mar 2, 2026
Remove basis_dict, can be easily implemented externally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Adds BandedTRF class for modeling features using TRFs trained with banded ridge regression.
Includes examples showing 1. That banded regularization outperforms standard TRFs by determining regularization separately for each feature and 2. BandedTRFs are dependent on the order of features used
Any other comments?