Skip to content

Solve issues of interrupting voice in process#18

Open
paalex wants to merge 14 commits into
naoufal:masterfrom
paalex:master
Open

Solve issues of interrupting voice in process#18
paalex wants to merge 14 commits into
naoufal:masterfrom
paalex:master

Conversation

@paalex

@paalex paalex commented Oct 13, 2016

Copy link
Copy Markdown
  • if voice is in process, a new call would queue the voice requests
  • to stop the voice, .stop() can be used as usual
  • solved a bug with boolean callbacks not crossing the bridge to
    react-native. @[[NSNull null], @true] instead of @[@true] (which
    produces an unhandled promise.

- if voice is in process, a new call would queue the voice requests
- to stop the voice, .stop() can be used as usual
- solved a bug with boolean callbacks not crossing the bridge to
react-native. @[[NSNull null], @true] instead of @[@true] (which
produces an unhandled promise.
@tarkanlar

Copy link
Copy Markdown

I am getting this error
node_modules/react-native-speech/SpeechSynthesizer.m:45:5: Use of undeclared identifier 'utterance'

- fixed - SpeechSynthesizer.m:45:5: Use of undeclared identifier
'utterance'
@paalex

paalex commented Oct 31, 2016

Copy link
Copy Markdown
Author

Sorry, fixed it now

@paalex

paalex commented Nov 9, 2016

Copy link
Copy Markdown
Author

Hey @tarkanlar ,
Can you check the latest commit?
It's working now.

@tarkanlar

Copy link
Copy Markdown

Hey @paalex thanks, I just tried. I am getting this error
image

@paalex

paalex commented Nov 12, 2016

Copy link
Copy Markdown
Author

Hey @tarkanlar ,
I changed the error to Info only ( will show only in console log).
Also added control over time intervals before\after the utterance and control over pitch and volume.
Bonus - event emitter for didFinishSpeechUtterance event.

best

Would like to merge the android support with updated ios library
@tarkanlar

Copy link
Copy Markdown

Works good Thanks @paalex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants