Fix README least-privilege policy: cluster-residue actions#28
Merged
Conversation
From the core-repos quality audit. The documented read-only IAM policy omitted the three actions the cluster-residue orphan scan calls — logs:DescribeLogGroups, events:ListRules, events:ListTagsForResource. Because that scan is best-effort (warns-and-skips on AccessDenied), a user with exactly the documented role got silent data loss (missing orphan findings, no visible error) on a headline feature. Added the three actions; dropped servicequotas:ListServiceQuotas, which the policy listed but no code path calls (only GetServiceQuota is used).
The .goreleaser description (which generates the Homebrew formula desc) was 150 chars — over Homebrew's 80-char audit limit. Shortened to an AWS-native one-liner under the limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the core-repos quality audit. The documented read-only IAM policy omitted the three actions the cluster-residue orphan scan calls (
logs:DescribeLogGroups,events:ListRules,events:ListTagsForResource). The scan warns-and-skips on AccessDenied, so a user with exactly the documented role got silent data loss (missing orphan findings, no error) on a headline feature. Added the three; droppedservicequotas:ListServiceQuotas(documented but never called — onlyGetServiceQuotais used).