Skip to content

Update gp_bases.py#441

Closed
churchilgw4 wants to merge 1 commit into
nanograv:masterfrom
churchilgw4:patch-1
Closed

Update gp_bases.py#441
churchilgw4 wants to merge 1 commit into
nanograv:masterfrom
churchilgw4:patch-1

Conversation

@churchilgw4

Copy link
Copy Markdown

Adding functionality to provide reference observing frequency for generic chromatic noise block

Adding functionality to provide reference observing frequency for generic chromatic noise block

@vhaasteren vhaasteren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but should be merged to dev, not master

@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (90dfa56) to head (f151158).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   71.58%   71.66%   +0.07%     
==========================================
  Files          13       13              
  Lines        3245     3240       -5     
==========================================
- Hits         2323     2322       -1     
+ Misses        922      918       -4     
Files with missing lines Coverage Δ
enterprise/signals/gp_bases.py 70.51% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6335ff7...f151158. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@churchilgw4

Copy link
Copy Markdown
Author

Closing PR due to test issues for macOS and Ubuntu

@churchilgw4 churchilgw4 closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants