Fix: use duck-typing in Pulsar() to determine whether we have a libstempo or PINT object#425
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #425 +/- ##
==========================================
+ Coverage 72.52% 72.59% +0.07%
==========================================
Files 13 13
Lines 3472 3478 +6
==========================================
+ Hits 2518 2525 +7
+ Misses 954 953 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…lized the duck-typing mechanism to check for callables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packages write tests in their test suite, sometimes Mock objects are used instead of libstempo/PINT pulsars. Or perhaps there are other reasons to not pass a libstempo/PINT object. Then Enterprise could still make a PintPulsar or a Tempo2Pulsar object if we were to use duck-typing. See #424
This PR updates it. No functionality is changed. Just a change from 'isinstance' to a duck-typing indicator function