Update GMRT coordinates#2002
Merged
Merged
Conversation
abhisrkckl
added
awaiting review
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
=======================================
Coverage 70.32% 70.32%
=======================================
Files 109 109
Lines 25745 25745
Branches 4106 4106
=======================================
Hits 18105 18105
Misses 6473 6473
Partials 1167 1167 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dlakaplan
reviewed
Jun 10, 2026
| else self.origin | ||
| ) | ||
| return f"TopoObs('{self.name}' ({','.join(aliases)}) at [{self.location.x}, {self.location.y} {self.location.z}]:\n{origin})" | ||
| return f"TopoObs('{self.name}' ({','.join(aliases)}) at [{self.location.x}, {self.location.y} {self.location.z}]:\n({origin})" |
Contributor
There was a problem hiding this comment.
This doesn't look right to me. I don't think you need that paren. I see:
TopoObs('gbt' ('1','gb') at [882589.289 m, -4924872.368 m 3943729.418 m]:
The Robert C. Byrd Green Bank Telescope
This data was obtained by Joe Swiggum from Ryan Lynch in 2021 September.
)
and I think the parentheses all close.
Contributor
Author
There was a problem hiding this comment.
OK... I have fixed it. The output now looks like this:
TopoObs(
'gbt' ('1','gb') at [882589.289 m, -4924872.368 m 3943729.418 m]:
The Robert C. Byrd Green Bank Telescope
This data was obtained by Joe Swiggum from Ryan Lynch in 2021 September.
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes a typo in
TopoObs.__repr__