Skip to content

Make tests run in parallel#1913

Merged
dlakaplan merged 10 commits into
nanograv:masterfrom
abhisrkckl:parallel-tests
Jun 10, 2025
Merged

Make tests run in parallel#1913
dlakaplan merged 10 commits into
nanograv:masterfrom
abhisrkckl:parallel-tests

Conversation

@abhisrkckl

@abhisrkckl abhisrkckl commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

The important changes are in ci_tests.yml and tox.ini. The rest are cleanup and formatting.

@codecov

codecov Bot commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (dcd3fa8) to head (ee0f5d4).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files         110      110           
  Lines       25705    25705           
  Branches     4056     4056           
=======================================
  Hits        17978    17978           
  Misses       6593     6593           
  Partials     1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhisrkckl abhisrkckl requested a review from dlakaplan June 10, 2025 10:11
@abhisrkckl

Copy link
Copy Markdown
Contributor Author

This was tried earlier in #1798, but had to be reverted because the macOS test kept failing. Since then, the macOS test was rewritten to work on M1 chips. So this should work, hopefully. I am not seeing any of the cryptic errors I was seeing with #1798 here.

@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Jun 10, 2025
@dlakaplan

Copy link
Copy Markdown
Contributor

That all looks pretty simple. Any rough estimate of the speedup?

@abhisrkckl

abhisrkckl commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

All times are in minutes. This includes the overhead of installing packages. Overall, I see ~2x improvement.

Test Before After
macos-latest-py313 88 46
oldestdeps 28 14
py313-test-cov 58 30

@dlakaplan

Copy link
Copy Markdown
Contributor

that's great. I can merge this when you are ready, or deal with #1910 first.

@abhisrkckl

Copy link
Copy Markdown
Contributor Author

They are independent. This can be merged.

@dlakaplan dlakaplan merged commit 2fa2b22 into nanograv:master Jun 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review This PR needs someone to review it so it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants