Rerun intermittent failures in CI#1866
Merged
Merged
Conversation
Contributor
Author
|
The macos failure is because the runner is deprecated. |
Contributor
|
I was also dealing with a situation like this, and in that case I just put in a fixed random seed so I know that it should pass if things work. but I don't know if that's a good idea in general? |
Contributor
Author
|
I think this is a more general solution. This also lets us know that we have a problem if the test fails even after 5 reruns. |
abhisrkckl
changed the title
Contributor
|
Since the new MacOS tests are no longer part of |
Contributor
Author
Added. |
Contributor
|
Looks good - should I merge? |
Contributor
Author
|
Yes
…On Tue, Dec 10, 2024, 18:06 David Kaplan ***@***.***> wrote:
Looks good - should I merge?
—
Reply to this email directly, view it on GitHub
<#1866 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6CGNY7W4J3QV3VNOS3TR32E4NRJAVCNFSM6AAAAABS7TUE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZSGMYDMMRZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was initially part of #1798 which was merged and then reverted.