Add submodule lmdbxx which is a c++ wrapper for lmdb

[clemahieu]

This change adds the lmdbxx submodule which is a c++ wrapper for LMDB. https://github.com/hoytech/lmdbxx

Currently we're using an amalgamation of direct access to the LMDB C API and some custom c++ wrapping of select portions of functionality.

Major motivations for using this library:

• Header-only
• C++17 language support
• Errors are exceptions
• RAII for LMDB resources
• Uses std::string_view for exchanging serialised objects which is compatible with rocksdb::Slice

The library has two implementation strategies, a near 1-to-1 wrapping of the C API with exception handling, and full RAII types. Migrating existing code to use the direct API was relatively painless and some of the RAII types can already be used.

The primary motivation for the change is to get a clear separation of the lmdb c++ wrapper from node-specific logic. Additionally, this removes the burden of wrapping the C API from the node code.

The library itself seems to make good design decisions and is reasonably maintained.

There are parts of the library which are not fully complete e.g. ::lmdb::dbi does not fully implement RAII, it is both copyable and doesn't destroy the underlying resources when it goes out of scope. To get full benefits we will likely have to upstream some patches which they will hopefully be receptive and responsive to.

[pwojcikdev]

Looks OK, but I'd argue that abandoning nano::store::lmdb::env class instead of embracing it and introducing nano::store::env as an abstraction for acid key-value stores is counterproductive to the goal of unifying lmdb and rocksdb codebases.

It also seems like assert for mismatched store ids got lost in the refactor, this would crash with mismatched store message on current develop:

TEST (block_store_DeathTest, transaction_mismatch)
{
	bool init;
	nano::store::lmdb::env env{ init, nano::unique_path () / "test.ldb" };
	ASSERT_FALSE (init);
	auto transaction = env.tx_begin_write ();

	nano::logger logger;
	auto store = nano::make_store (logger, nano::unique_path (), nano::dev::constants);
	ASSERT_FALSE (store->init_error ());

	ASSERT_DEATH (store->block.begin (transaction), "");
}

[gr0vity-dev-bot]

Test Results for Commit 519f57e

Pull Request 4724: Results
Overall Status: ❌

Test Case Results

• ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 113s)
• ❌ 5n4pr_conf_10k_change: FAIL (Duration: 148s)
• Log
• ❌ 5n4pr_conf_change_dependant: FAIL (Duration: 108s)
• Log
• ❌ 5n4pr_conf_send_dependant: FAIL (Duration: 92s)
• Log
• ❌ 5n4pr_conf_send_independant: FAIL (Duration: 97s)
• Log
• ✅ 5n4pr_rocks_10k_bintree: PASS (Duration: 179s)
• ❌ 5n4pr_rocks_10k_change: FAIL (Duration: 270s)
• Log

Last updated: 2025-02-25 19:19:35 UTC