Skip to content

Increased test coverage#164

Merged
eskenazit merged 1 commit intomainfrom
chore/increase-test-coverage
Mar 20, 2026
Merged

Increased test coverage#164
eskenazit merged 1 commit intomainfrom
chore/increase-test-coverage

Conversation

@jlouvel
Copy link
Contributor

@jlouvel jlouvel commented Mar 20, 2026

  • added focused tests for lookup execution,
  • external ref resolution,
  • converter behaviors,
  • HTTP auth handling,
  • step orchestration,
  • ResourceRestlet mapping/mock flows

added focused tests for lookup execution, external ref resolution, converter behaviors, HTTP auth handling, step orchestration, and ResourceRestlet mapping/mock flows
@jlouvel jlouvel requested a review from eskenazit March 20, 2026 16:17
@jlouvel jlouvel self-assigned this Mar 20, 2026
@eskenazit
Copy link
Contributor

@jlouvel Quick question (not blocking), this PR does not follow the PR template, was it not proposed to you in your GitHub Workspace context ?

@jlouvel
Copy link
Contributor Author

jlouvel commented Mar 20, 2026

It was proposed but as I had prepared my commit message offline, I just replaced the template text with my bullet points. Let's discuss if the template is preferred/mandatory for maintainers as well.

@eskenazit
Copy link
Contributor

If we want other to follow our rules, we should follow them ourselves =)

Copy link
Contributor

@eskenazit eskenazit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit merged commit 1bbf8b2 into main Mar 20, 2026
2 checks passed
@eskenazit eskenazit deleted the chore/increase-test-coverage branch March 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants