Skip to content

M19.1: Pin MAIL_OUTBOUND_ENABLED=true in phpunit.xml #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n8bar merged 2 commits into from
May 10, 2026
Merged

M19.1: Pin MAIL_OUTBOUND_ENABLED=true in phpunit.xml #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b1857f
Pin MAIL_OUTBOUND_ENABLED=true in phpunit.xml; resolve M19.1 carried-…
n8bar May 10, 2026
cbabf2c
Rename completed M18 strategy docs with x prefix
n8bar May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/strategies/19.1_NOTIFICATION_COVERAGE_AUDIT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Parent milestone doc: [`docs/milestones/19_RC_HARDENING_OPS.md`](../milestones/1

`Tests\Feature\InvoiceNotificationTest` has been failing across every recent PR back to MS17 — past-due delivery assertions expect `queued` but observe `skipped`/`sent`. Diagnosed as CI environment / test reliability issue, not caused by any specific PR's changes. Falls within this phase's scope (notification surface audit) and **must be resolved before Phase 1 closes** — explicit user direction at MS19 PR merge.

**Resolution:** Tracked and fixed via [#68](https://github.com/n8bar/CryptoZing/issues/68). First Issue under the M19 GitHub Issues trial (see milestone doc Decisions recorded).

## 1. Enumerate the live mail surface

1. [ ] Re-list every Mail class under `app/Mail/` directly from disk; do not trust the snapshot in the Reference section without re-verifying.
Expand Down Expand Up @@ -51,7 +53,7 @@ Parent milestone doc: [`docs/milestones/19_RC_HARDENING_OPS.md`](../milestones/1
- [ ] Every notice class named in spec Sections 3–5 has a matching matrix row.
- [ ] Drift findings are either fixed in this phase or recorded in `BACKLOG.md` with context.
- [ ] `(MS17 deliverable)` placeholder text is removed from the spec heading.
- [ ] CI flakiness in `Tests\Feature\InvoiceNotificationTest` (past-due delivery status: expected `queued`, observed `skipped`/`sent`) investigated and resolved. Tests pass green on a Phase-1-close PR.
- [x] CI flakiness in `Tests\Feature\InvoiceNotificationTest` (past-due delivery status: expected `queued`, observed `skipped`/`sent`) investigated and resolved. Tests pass green on a Phase-1-close PR. (Resolved via [#68](https://github.com/n8bar/CryptoZing/issues/68).)

## Reference

Expand Down
0 ...gies/18.2_CONTENT_AUDIT_AND_PRODUCTION.md → ...ies/x18.2_CONTENT_AUDIT_AND_PRODUCTION.md
View file
Open in desktop
File renamed without changes.
0 .../18.3_SITE_ARCHITECTURE_AND_PUBLISHING.md → ...x18.3_SITE_ARCHITECTURE_AND_PUBLISHING.md
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
<env name="CACHE_STORE" value="array"/>
<env name="DB_DATABASE" value="testing"/>
<env name="MAIL_MAILER" value="array"/>
<env name="MAIL_OUTBOUND_ENABLED" value="true"/>
<env name="QUEUE_CONNECTION" value="sync"/>
<env name="SESSION_DRIVER" value="array"/>
<env name="PULSE_ENABLED" value="false"/>
Expand Down
Loading