feat(quick-links): Add VCT 2024 and 2025 to quick links / Refactored trophies.js #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tino-sv wants to merge 1 commit into myhiy:master from tino-sv:feature/quick-links-and-trophies-fixes

tino-sv commented Nov 20, 2025

Changes Made

Added VCT 2024 and 2025 to quick links dropdown
Added VCT 2024 and 2025 to quick links settings panel
Added detailed debug logging for trophy initialization

Bug Fixes

Fixed race condition in script loading
Added proper error handling to prevent script failures
Fixed potential XSS vulnerabilities in trophy display

Refactoring

Reduced code duplication in trophies.js
Improved code organization and documentation
Enhanced error handling and logging

Testing

Verified quick links for VCT 2024 and 2025 appear in dropdown
Confirmed quick links are configurable in settings
Verified trophies display correctly on team/player pages
Tested error handling with invalid data

Notes

The console may show a "net::ERR_FILE_NOT_FOUND" error for trophies.js, but this is a false positive im pretty sure
All new quick links follow the same pattern as existing ones. They do use the VCT 23 Image, though.
Hopefully this brings back a great extension.


          feat(quick-links): Add VCT 2024 and 2025 to quick links

fa5292f

refactor(trophies): Improve code quality and initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet