added assignment 1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
[heart] Myesha Senior reacted to your message:
…________________________________
From: juliagallucci ***@***.***>
Sent: Tuesday, October 21, 2025 7:54:55 PM
To: myeshasenior1/python ***@***.***>
Cc: Myesha Senior ***@***.***>; Author ***@***.***>
Subject: Re: [myeshasenior1/python] added assignment 1 (PR #1)
@juliagallucci approved this pull request.
Great!
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BX6IBTTEGPDR3VK7SZUGBJL3Y2FQ7AVCNFSM6AAAAACJT3A2ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNRSGUYDEMJUGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I was adding code and then refactoring existing code
What did you learn from the changes you have made?
I learned how to define a function and then use that to easily check on strings using boolean operators.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about using 'and' and 'or' operators for this but wasn't sure.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I was having a bit of trouble with originally setting up the case checker and the sort function because of the formatting. I just tried a couple of ways and also read the syntax errors to understand where I was going wrong.
How were these changes tested?
I just ran the code on visual studio and tracked the changes.
A reference to a related issue in your repository (if applicable)
n/a
Checklist