Conversation
Added test cases covering happy paths (None, ReadOnly, sub-span) and error conditions (Null, zero size). Also added a negative test that forks a child process to reliably trigger and verify native unmanaged memory crashes (AccessViolationException/segfault) when writing to ReadOnly protected memory. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed
This PR addresses the lack of test coverage for
NativeAllocator.ApplyProtection().📊 Coverage: What scenarios are now tested
nullor size0.MemoryProtectionMode.NoneandMemoryProtectionMode.ReadOnlydynamically.MemoryProtectionMode.ReadOnlymemory throws an unmanaged crash (which is handled safely by isolating the crash in a child process, making the test portable and stable across CI pipelines).✨ Result: The improvement in test coverage
The test coverage for
NativeAllocatoris now much more robust, ensuring the memory protection functionality behaves predictably and OS-specific functions (mprotect/VirtualProtect) correctly restrict read and write access across all supported backends.PR created automatically by Jules for task 604321551949943287 started by @myarichuk