Fix CWE-209 stack trace information exposure in UnifiedGraphWriterMulti#9
Open
Fix CWE-209 stack trace information exposure in UnifiedGraphWriterMulti#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 1 security vulnerability identified by BoostSecurity.
Remove printStackTrace to prevent exception info exposure in
src/scala/com/twitter/recos/hose/common/UnifiedGraphWriterMulti.scala(Line: 126)Risk:
Exception.printStackTrace()printed detailed internal stack traces to stderr, exposing implementation details and potentially sensitive data (CWE-209).Fix: Removed
printStackTrace()and replaced it with structured error logging vialog.error(e, ...), preserving diagnostics in application logs without dumping stack traces to standard error.Review notes: Logging output changes slightly (new message text), but error handling/cleanup behavior is unchanged.
Generated by BoostSecurity Advisor