Remove stack trace printing to prevent info exposure#15
Open
Remove stack trace printing to prevent info exposure#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 1 security vulnerability identified by BoostSecurity.
Remove stack trace printing in RecosEdgeProcessor in
src/scala/com/twitter/recos/hose/common/RecosEdgeProcessor.scala(Line: 36)Risk:
Exception.printStackTrace()inRecosEdgeProcessorcould expose internal class names, file paths, and line numbers via stderr, enabling information disclosure (CWE-209).Fix: Removed the
printStackTrace()call and retained error accounting via the existingprocess_errorscounter while returningFuture.Unitas before.Review notes: This reduces diagnostic output on failures; monitoring should rely on the error counter/metrics rather than stderr stack traces.
Generated by BoostSecurity Advisor