Skip to content

Fix information exposure by removing printStackTrace #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victor-nb wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Fix information exposure by removing printStackTrace #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/scala/com/twitter/recos/hose/common/RecosEdgeProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.twitter.recos.hose.common
import com.twitter.finagle.stats.StatsReceiver
import com.twitter.recos.internal.thriftscala.RecosHoseMessage
import com.twitter.util.Future
import com.twitter.util.logging.Logger
import org.apache.kafka.clients.consumer.ConsumerRecord

/**
Expand All @@ -13,6 +14,8 @@ case class RecosEdgeProcessor(
)(
implicit statsReceiver: StatsReceiver) {

private val log = Logger.get(getClass)

private val scopedStats = statsReceiver.scope("RecosEdgeProcessor")

private val processEventsCounter = scopedStats.counter("process_events")
Expand All @@ -33,7 +36,7 @@ case class RecosEdgeProcessor(
} catch {
case e: Throwable =>
errorCounter.incr()
e.printStackTrace()
log.error(e, "error processing recos hose message")
Future.Unit
}
}
Expand Down
Loading