-
Notifications
You must be signed in to change notification settings - Fork 1
Add the brand_color_hex_code into the predirect page #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I tried testing this and I am not seeing the new pre-direct screen am I supposed to turn on a feature flag for my client to see this new screen? |
I need to write up the specific instructions on how to test this. I'll reach out when I have those ready, and request a review then. Thank you @ash-wright123 ! |
d9c8313 to
b7b638b
Compare
@ash-wright123 this now has more specific instructions in how to test it. |
|
looks good |
ash-wright123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested well for me LGTM
Jameson13B
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Good work Logan!
|
π This PR is included in version 2.17.0 π The release is available on: Your semantic-release bot π¦π |
Dependency
β The code has been merged - π« This was blocked by #267 π«
The refactor in 267 must be merged first
Feature Summary
Institution Brand Color
Institutions can have a defined hex code for their brand. Eventually, it will be an option of a few colors in Batcave chosen by someone at MX. When picked, that color should show up in the widget header on the OAuth predirect page for that institution:
For instance... if Wells Fargo has one of our red colors selected it will show up like this:
Internal Jira reference: https://mxcom.atlassian.net/browse/CTT-76
Institution Aggregator Instructions
Institution Aggregators can display multiple checkboxes to instruct the user what to do on external websites. When configured by MX, the options can look like this:
Internal Jira reference: https://mxcom.atlassian.net/browse/CTT-77
Testing Instructions
To test this new OAuth functionality, the code-base that is using the npm package must start sending
oauth_predirect_instructionsandbrand_color_hex_codevalues in the response to the API request for an institution. This can be hard-coded for testing purposes, because the configuration backend is not yet ready.Note - Wells Fargo will always show the new experience with a red color and ACCOUNT_AND_TRANSACTIONS_INSTRUCTION and PROFILE_INFORMATION_INSTRUCTION, unless the API response comes back with values, in which case, the specific values will be used.
Each oauth_predirect_instructions value matches up accordingly: