Skip to content

feat(app): add local image import workflows#375

Merged
murongg merged 3 commits into
mainfrom
feature/import-local-images
Jun 22, 2026
Merged

feat(app): add local image import workflows#375
murongg merged 3 commits into
mainfrom
feature/import-local-images

Conversation

@murongg

@murongg murongg commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a local image import flow that saves selected system images into the document image location and inserts Markdown image references.
  • Support dragging image assets from the file tree into the editor, including Tauri/WebView fallbacks when native editor drop payloads are unreliable.
  • Support system image file drops into the editor without copying them into assets, preserving the dropped local path reference.
  • Improve image-drop editor behavior: blank-line replacement, stable selection after insertion, duplicate drop/dragend guarding, and path encoding for special characters.

Why

Validation

  • pnpm vitest run src/components/MarkdownFileTreeDrawer.test.tsx passed
  • pnpm vitest run src/App.test.tsx passed
  • pnpm vitest run src/components/MarkdownPaper.test.tsx passed
  • pnpm --filter @markra/shared test passed
  • pnpm --filter @markra/app typecheck:test passed
  • pnpm --filter @markra/editor typecheck:test passed
  • pnpm --filter @markra/shared typecheck:test passed
  • git diff --check passed
  • git diff --cached --check passed

Risk

  • Desktop drag/drop behavior can vary by platform and WebView; the implementation includes custom MIME, plain Markdown, native file-drop, and dragend fallbacks. Not run: additional manual desktop QA after the final cleanup pass.

@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 22, 2026 12:58am

@murongg murongg merged commit 2f3e79d into main Jun 22, 2026
4 checks passed
@murongg murongg deleted the feature/import-local-images branch June 22, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant