Skip to content

fix(editor): restore horizontal rule selection#374

Merged
murongg merged 1 commit into
mainfrom
fix/hr-selection
Jun 21, 2026
Merged

fix(editor): restore horizontal rule selection#374
murongg merged 1 commit into
mainfrom
fix/hr-selection

Conversation

@murongg

@murongg murongg commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Make horizontal rule clicks select the rule node directly, including rules below images and adjacent rules.
  • Preserve surrounding-gap click protection while allowing the full rule hit target to select.
  • Allow Backspace/Delete from empty paragraphs around horizontal rules to remove the blank paragraph and select the rule.

Why

Horizontal rules could lose their selectable hit target when adjacent to images or blank paragraphs, which also made nearby empty lines feel impossible to delete.

Validation

  • pnpm vitest run src/components/MarkdownPaper.test.tsx
  • pnpm --filter @markra/app typecheck:test
  • git diff --check

Risk

  • Low; scoped to horizontal-rule click handling and adjacent empty-paragraph keyboard behavior.

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 21, 2026 12:50pm

@murongg murongg marked this pull request as ready for review June 21, 2026 12:54
@murongg murongg merged commit 5477360 into main Jun 21, 2026
4 checks passed
@murongg murongg deleted the fix/hr-selection branch June 21, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant