Skip to content

🔧 Bump minimum scikit-build-core version#1544

Merged
denialhaag merged 6 commits intomainfrom
update-scikit-build-core
Mar 6, 2026
Merged

🔧 Bump minimum scikit-build-core version#1544
denialhaag merged 6 commits intomainfrom
update-scikit-build-core

Conversation

@denialhaag
Copy link
Copy Markdown
Member

@denialhaag denialhaag commented Mar 6, 2026

Description

This PR bumps the minimum scikit-build-core version to 0.12.2 to ensure we are making use of the new sdist.inclusion-mode setting.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Mar 6, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file python Anything related to Python code labels Mar 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread .github/workflows/cd.yml
@denialhaag denialhaag requested a review from burgholzer March 6, 2026 14:34
@denialhaag denialhaag marked this pull request as ready for review March 6, 2026 14:34
Copy link
Copy Markdown
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denialhaag denialhaag enabled auto-merge (squash) March 6, 2026 16:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ec2ed62f-28d8-4130-b0bf-21e0cbe494db

📥 Commits

Reviewing files that changed from the base of the PR and between df4c12f and 933370c.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/cd.yml
  • pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated build tool dependencies to improve compatibility and stability.

Walkthrough

Updated the minimum version of scikit-build-core from 0.11.6 to 0.12.2 in build configuration. Reformatted a comment in the CI/CD workflow from multiple lines into a single line.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/cd.yml
Comment text about wheel artifacts reformatted from two lines to one line; no functional changes.
Build Dependencies
pyproject.toml
Minimum version of scikit-build-core bumped from 0.11.6 to 0.12.2 in build-system requires and build dependency group.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A version hop, a comment's tidy fold,
Dependencies upgraded, stronger and bold!
Scikit-build-core takes a leap forward with grace,
While cleaner comments brighten the workflow's space.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: bumping the minimum scikit-build-core version. It is specific, concise, and directly related to the changeset.
Description check ✅ Passed The description addresses the main change with clear motivation (using new sdist.inclusion-mode setting) and covers most required checklist items. Only non-applicable items are unchecked, which is appropriate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-scikit-build-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@denialhaag denialhaag disabled auto-merge March 6, 2026 16:15
@denialhaag denialhaag enabled auto-merge (squash) March 6, 2026 16:15
@denialhaag denialhaag merged commit 67027a2 into main Mar 6, 2026
30 checks passed
@denialhaag denialhaag deleted the update-scikit-build-core branch March 6, 2026 16:43
@denialhaag denialhaag mentioned this pull request Apr 18, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Anything related to Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants