fix(struct): prevent erroneous caching of struct types#89
Merged
Wodann merged 1 commit intomun-lang:masterfrom Jan 30, 2020
Merged
fix(struct): prevent erroneous caching of struct types#89Wodann merged 1 commit intomun-lang:masterfrom
Wodann merged 1 commit intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 76.68% 76.84% +0.15%
==========================================
Files 122 122
Lines 9827 9833 +6
==========================================
+ Hits 7536 7556 +20
+ Misses 2291 2277 -14
Continue to review full report at Codecov.
|
Wodann
force-pushed
the
fix/cached-struct-type
branch
from
378858b to
2b49d4c
Compare
Collaborator
Author
Wodann
force-pushed
the
fix/cached-struct-type
branch
2 times, most recently
from
af08c46 to
7789f99
Compare
baszalmstra
approved these changes
Jan 29, 2020
Collaborator
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Alternatively, maybe for later, we could change the IR signature of functions for GC types. Instead of storing pointers to the GC value we should store a 'GCHandle' instead of a typed pointer. Then we won't have to modify the referencing struct anymore.
Prevents salsa from returning cached struct types, when you change the type of one of the struct fields
Wodann
force-pushed
the
fix/cached-struct-type
branch
from
7789f99 to
4c850ab
Compare
Collaborator
Author
Wodann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #88