Skip to content

feat: add simple binary operation type checking#70

Merged
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:binary_op_typecheck
Dec 30, 2019
Merged

feat: add simple binary operation type checking#70
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:binary_op_typecheck

Conversation

@baszalmstra
Copy link
Collaborator

This PR basically adds checks to determine whether a binary operation is valid. This test should report an error:

fn foo() {
    let b = false;
    let n = 1;
    let _ = b + n; // error: invalid binary operation
}

@baszalmstra baszalmstra self-assigned this Dec 29, 2019
@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          81     81           
  Lines        5604   5628   +24     
=====================================
- Misses       5604   5628   +24
Impacted Files Coverage Δ
crates/mun_hir/src/expr.rs 0% <0%> (ø) ⬆️
crates/mun_hir/src/ty/infer.rs 0% <0%> (ø) ⬆️
crates/mun_hir/src/ty/tests.rs 0% <0%> (ø) ⬆️
crates/mun_hir/src/ty/op.rs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a4efc...518f1d1. Read the comment docs.

@baszalmstra baszalmstra merged commit d048a8f into mun-lang:master Dec 30, 2019
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants