feat: add manual generation of abi, runtime-capi#69
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Jan 3, 2020
Merged
feat: add manual generation of abi, runtime-capi#69baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra merged 1 commit intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 71.83% 71.92% +0.09%
==========================================
Files 106 109 +3
Lines 7228 7270 +42
==========================================
+ Hits 5192 5229 +37
- Misses 2036 2041 +5
Continue to review full report at Codecov.
|
baszalmstra
force-pushed
the
manual_generation
branch
2 times, most recently
from
63a49e4 to
5e1d322
Compare
Collaborator
|
Is it necessary to do this for the CAPI too? |
Collaborator
Author
Appears to be the case yes. Without this, cargo always detects changes. |
Wodann
requested changes
Dec 29, 2019
baszalmstra
force-pushed
the
manual_generation
branch
2 times, most recently
from
cff4356 to
77b8e19
Compare
baszalmstra
force-pushed
the
manual_generation
branch
2 times, most recently
from
686178c to
e5a2cf8
Compare
Collaborator
|
Do you have any idea why the gen-runtime-capi check is failing just for ubuntu beta? |
Collaborator
Author
No, I cant reproduce it either. But Im working on it. :) |
baszalmstra
force-pushed
the
manual_generation
branch
from
e5a2cf8 to
1051e1f
Compare
When using build.rs files several files get regenerated every build which causes rebuilds even when nothing really changed. This commit changes this behavior to make the user manually run a command when the files should be regenerated.
baszalmstra
force-pushed
the
manual_generation
branch
from
1051e1f to
71476b7
Compare
Wodann
approved these changes
Jan 3, 2020
8 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using build.rs files several files get regenerated every build
which causes rebuilds even when nothing really changed. This commit
changes this behavior to make the user manually run a command when the
files should be regenerated.