feat: adds detection of duplicate definition names#5
Merged
Wodann merged 1 commit intomun-lang:masterfrom Oct 5, 2019
Merged
Conversation
Collaborator
Author
baszalmstra
force-pushed
the
duplicate-symbols
branch
from
d864376 to
1a3a3a3
Compare
baszalmstra
force-pushed
the
duplicate-symbols
branch
from
1a3a3a3 to
a9f01fd
Compare
Wodann
approved these changes
Oct 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thing that is still missing in the PR is a test to actually check that this works but currently there is no testing framework to test HIR in the first place.