fix: parser performance issues#307
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Feb 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 81.42% 81.41% -0.01%
==========================================
Files 239 239
Lines 14026 14025 -1
==========================================
- Hits 11420 11419 -1
Misses 2606 2606
Continue to review full report at Codecov.
|
Wodann
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a loop that iterates over a lot of elements that accidentally loops O(n) times where it should be O(n). This caused huge performance issues that this MR fixes.
The change looks more complicated than it actually is. What was happening was this:
where it should be:
This caused completions in a large file that I'm using to go from 300ms to 3ms but it affected all operations.