fix: manually extract llvm release to get more output#302
Merged
baszalmstra merged 2 commits intomun-lang:masterfrom Jan 23, 2021
Merged
fix: manually extract llvm release to get more output#302baszalmstra merged 2 commits intomun-lang:masterfrom
baszalmstra merged 2 commits intomun-lang:masterfrom
Conversation
36654be to
55f2efd
Compare
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 239 239
Lines 14026 14026
=======================================
Hits 11420 11420
Misses 2606 2606 Continue to review full report at Codecov.
|
55f2efd to
e2c9082
Compare
Wodann
approved these changes
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building this PR the windows action failed again while un7ziping due to with the file being unzipped still being in use by another process. I assume this is the extraction? I updated the code to retry 5 times and wait 1 second in between.
This PR calls 7z directly instead of relying in toolcache. This then outputs a lot of information about the 7zip process which is what we are currently still missing. The output of the install LLVM step now looks like this: