feat(language server): removed async code and switched to lsp_server #295
Merged
baszalmstra merged 2 commits intomun-lang:masterfrom Jan 16, 2021
Merged
feat(language server): removed async code and switched to lsp_server #295baszalmstra merged 2 commits intomun-lang:masterfrom
baszalmstra merged 2 commits intomun-lang:masterfrom
Conversation
0a6af9e to
2b08ebe
Compare
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 78.76% 80.77% +2.00%
==========================================
Files 236 237 +1
Lines 13866 13864 -2
==========================================
+ Hits 10922 11199 +277
+ Misses 2944 2665 -279
Continue to review full report at Codecov.
|
Collaborator
Author
|
I also added some basic functionalities for testing the language server properly. This now also fixes the shortcomings in #293 where the language server was slower than the tests. With the new vfs we can now wait until the entire workspace is loaded before requesting information about it. |
3bb4624 to
dc79dda
Compare
dc79dda to
e950f85
Compare
e950f85 to
6a72006
Compare
Wodann
requested changes
Jan 16, 2021
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Looks good overall. Some minor change requests.
6a72006 to
7119fe0
Compare
Wodann
requested changes
Jan 16, 2021
7119fe0 to
c7e0c7b
Compare
Wodann
approved these changes
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #294
This PR removes all async code and switch to the use of the
lsp_servercrate instead of using our own.