fix(codegen): alignment of struct fields#285
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Oct 24, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 79.39% 79.39%
=======================================
Files 220 220
Lines 13004 13004
=======================================
Hits 10324 10324
Misses 2680 2680
Continue to review full report at Codecov.
|
Wodann
force-pushed
the
fix/struct-field-alignment
branch
from
25f6894 to
64942d9
Compare
baszalmstra
requested changes
Oct 24, 2020
Collaborator
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
This looks very good! Thanks! 👍
Most of my comments are about adding some comments, I find it hard to figure out exactly what is going on.
Wodann
force-pushed
the
fix/struct-field-alignment
branch
from
64942d9 to
2ce4f50
Compare
baszalmstra
approved these changes
Oct 24, 2020
Wodann
force-pushed
the
fix/struct-field-alignment
branch
from
2ce4f50 to
b70fe84
Compare
Wodann
force-pushed
the
fix/struct-field-alignment
branch
from
b70fe84 to
48e1a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #274.