feature: adds modules and visibility#283
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Nov 4, 2020
Merged
Conversation
baszalmstra
added
type: feat
baszalmstra
force-pushed
the
feature/pub
branch
from
6c5d31b to
8433895
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 79.34% 79.73% +0.39%
==========================================
Files 220 228 +8
Lines 13069 13500 +431
==========================================
+ Hits 10369 10764 +395
- Misses 2700 2736 +36
Continue to review full report at Codecov.
|
Wodann
requested changes
Oct 15, 2020
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
Very happy to see this work nearing completion. Mun v0.3 is shaping up nicely!
This is only a partial review, but I wanted to make sure that part of my comments were already actionable. I'll continue the review later.
Wodann
requested changes
Oct 17, 2020
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
The next batch of reviewed files 😅
baszalmstra
force-pushed
the
feature/pub
branch
from
4347dd2 to
702e615
Compare
Collaborator
Author
|
I think I solved all issues, also rebased everything on current master. |
Wodann
requested changes
Oct 25, 2020
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
The last batch of comments. Hopefully we can merge this soon 🌲
baszalmstra
force-pushed
the
feature/pub
branch
2 times, most recently
from
b1e14eb to
95f3c65
Compare
baszalmstra
force-pushed
the
feature/pub
branch
from
95f3c65 to
6747bbc
Compare
Wodann
approved these changes
Oct 29, 2020
baszalmstra
force-pushed
the
feature/pub
branch
from
6747bbc to
56530c0
Compare
baszalmstra
force-pushed
the
feature/pub
branch
from
474f0bb to
9da3be5
Compare
Wodann
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (still way too large, Im sorry 😓 ) PR adds use of
pubkeywords and resolved visibility. It also introduces the concept of modules which are ordered in a hierarchical manner based on their location on disk. This is required to be able to specify visibility scopes. This PR also (again Im sorry for the size 😓 ) introduces the concept of definitions from all over the package in the form of PackageDefs. This can later be used to more easily implementuseas well.All of this required quite the overhaul, especially because we have modules now instead of files.
Closes #248
This PR is still in Draft because I want to:
add diagnostics for missing module files (We decided that that is actually not an error.foo/exists but nomod.rsorfoo.rs).