misc: split database and added docs#267
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Sep 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 79.08% 79.05% -0.04%
==========================================
Files 214 214
Lines 12803 12808 +5
==========================================
Hits 10125 10125
- Misses 2678 2683 +5
Continue to review full report at Codecov.
|
Wodann
requested changes
Sep 12, 2020
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Good to have this documentation, and the code is also a lot more concise. Thanks for this!
How did you make the diagram? I like the style! 🙂
4a9d9f8 to
2973128
Compare
Collaborator
Author
It's basically draw.io with a custom font: https://drawio-app.com/introducing-draw-ios-new-sketch-feature/ |
2973128 to
996dd4f
Compare
Wodann
approved these changes
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It required some effort to understand the codebase so I thought it was time to add a bunch of documentation. I also split some of the databases into different databases to get a better grouping.