fix: emit and link bitcode files instead of obj does not work on MacOS#261
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Aug 29, 2020
Merged
Conversation
…ect files" This reverts commit 0736239.
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 78.74% 78.75%
=======================================
Files 215 215
Lines 12853 12857 +4
=======================================
+ Hits 10121 10125 +4
Misses 2732 2732
Continue to review full report at Codecov.
|
Wodann
approved these changes
Aug 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0736239 or MR #258 . It doesnt work when generating MacOS binaries (build actually failed..).
For MacOS we would have to generate object files so we would have two code paths. Id rather then just use object files for all platforms.