fix: removed outdated comments#245
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Jul 17, 2020
Merged
Conversation
Collaborator
|
We try to follow the Conventional Commits format as outlined in our contributing guide. Could you update your commit messages to reflect that? |
Contributor
Author
|
@baszalmstra Done. |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 78.94% 80.78% +1.83%
==========================================
Files 196 189 -7
Lines 12608 12239 -369
==========================================
- Hits 9954 9887 -67
+ Misses 2654 2352 -302
Continue to review full report at Codecov.
|
Collaborator
|
If you rebase on current master the CI will no longer fail. |
These comments are misleading as the functions do not return `bool`s
Contributor
Author
|
@baszalmstra Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments are misleading as the functions do not return
bools