Skip to content

refactor: upgrade to salsa 0.15#244

Merged
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:misc/salsa_0_15_upgrade
Jul 17, 2020
Merged

refactor: upgrade to salsa 0.15#244
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:misc/salsa_0_15_upgrade

Conversation

@baszalmstra
Copy link
Collaborator

Salsa 0.15 introduces dyn databases as oposed to impl databases. This decreases compilation time by 30% in my tests.

@Wodann Wodann added this to the Mun v0.3.0 milestone Jul 17, 2020
@Wodann Wodann added the type: perf Changes that improve performance label Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #244 into master will decrease coverage by 1.92%.
The diff coverage is 47.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   80.78%   78.86%   -1.93%     
==========================================
  Files         189      196       +7     
  Lines       12239    12626     +387     
==========================================
+ Hits         9887     9957      +70     
- Misses       2352     2669     +317     
Impacted Files Coverage Δ
crates/mun/src/lib.rs 52.10% <ø> (ø)
crates/mun_codegen/src/db.rs 100.00% <ø> (ø)
crates/mun_compiler/src/diagnostics_snippets.rs 91.93% <ø> (ø)
crates/mun_compiler/src/driver.rs 55.69% <ø> (ø)
crates/mun_compiler/src/driver/display_color.rs 71.42% <ø> (ø)
crates/mun_compiler_daemon/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_hir/src/diagnostics.rs 66.50% <0.00%> (ø)
...mun_hir/src/expr/validator/literal_out_of_range.rs 54.16% <ø> (ø)
crates/mun_hir/src/tests.rs 84.61% <ø> (ø)
crates/mun_hir/src/ty/infer/coerce.rs 94.11% <ø> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0635c2d...c38ae3d. Read the comment docs.

@baszalmstra baszalmstra force-pushed the misc/salsa_0_15_upgrade branch 3 times, most recently from f2303a7 to 9ad7519 Compare July 17, 2020 14:22
@baszalmstra baszalmstra force-pushed the misc/salsa_0_15_upgrade branch from 9ad7519 to c38ae3d Compare July 17, 2020 14:38
@baszalmstra baszalmstra merged commit 13e4464 into mun-lang:master Jul 17, 2020
@Wodann Wodann added type: refactor Refactor existing code and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Refactor existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants