fix(parser): parsing of unmatched right curly braces ('}')#243
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Jul 15, 2020
Merged
fix(parser): parsing of unmatched right curly braces ('}')#243baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra merged 1 commit intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 81.10% 81.10%
=======================================
Files 189 189
Lines 12325 12325
=======================================
Hits 9996 9996
Misses 2329 2329
Continue to review full report at Codecov.
|
Collaborator
|
Thanks for this! 👍 |
Collaborator
|
Thanks for finding and fixing this bug @emigr2k1. A recommendation for the future would be to also add a test that causes the crash to our test suite - along with the fix. That way we can check for regressions, going forward :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.