fix: fixes a lot of llvm assertions#233
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Jun 23, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 81.14% 81.11% -0.04%
==========================================
Files 182 182
Lines 11968 11996 +28
==========================================
+ Hits 9711 9730 +19
- Misses 2257 2266 +9
Continue to review full report at Codecov.
|
Wodann
reviewed
Jun 21, 2020
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
Nice fixes. I have one remark and one question
baszalmstra
force-pushed
the
fix/issue_227
branch
from
4ad5bd1 to
c173381
Compare
Wodann
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a lot of LLVM assertions that were caused by invalid struct assignments due to casts being invalid. I introduced the
Value::with_castmethod to introduce an explicit cast.Fixes these issues was a pain because the test just crashed. I had to insert a lot of print statements. I left some of them in (commented out) so in the future, it will be easier to fix these issues.
Closes #227