Skip to content

fix: fixes issue #228#229

Merged
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:fix/issue_228
Jun 18, 2020
Merged

fix: fixes issue #228#229
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:fix/issue_228

Conversation

@baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Jun 17, 2020

Fixes a few issues (presented in #228):

  • In IR: When a block had a tailing expression with a never type the block would return an empty struct.
  • If the then block of an if/else expression had a never type, it would return an empty struct instead of the result of the if statement.
  • If the then block and the else block have a never type, the if would return an empty struct.

@baszalmstra baszalmstra self-assigned this Jun 17, 2020
@baszalmstra baszalmstra added the type: fix Bug fix or report label Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #229 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   81.06%   81.13%   +0.06%     
==========================================
  Files         182      182              
  Lines       11933    11938       +5     
==========================================
+ Hits         9674     9686      +12     
+ Misses       2259     2252       -7     
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/body.rs 84.96% <100.00%> (-0.09%) ⬇️
crates/mun_codegen/src/test.rs 98.23% <100.00%> (+0.03%) ⬆️
crates/mun_target/src/abi/mod.rs 56.73% <0.00%> (+3.84%) ⬆️
crates/mun_hir/src/ty/primitives.rs 68.18% <0.00%> (+4.54%) ⬆️
crates/mun_hir/src/ty/resolve.rs 68.75% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2ff36...406da2e. Read the comment docs.

@baszalmstra baszalmstra merged commit e080d77 into mun-lang:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix or report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants