Skip to content

fix(codegen): crash on missing nested private function#221

Merged
Wodann merged 1 commit intomun-lang:masterfrom
Wodann:fix/nested-private-fn
Jun 14, 2020
Merged

fix(codegen): crash on missing nested private function#221
Wodann merged 1 commit intomun-lang:masterfrom
Wodann:fix/nested-private-fn

Conversation

@Wodann
Copy link
Collaborator

@Wodann Wodann commented Jun 12, 2020

This is a fix for the Mun v0.2 release, which should also be cherry-picked/pushed to the release/v0.2 branch and released as v0.2.1 (at some point).

We've also discussed a more elaborate solution where we first do a pass to determine all "used" functions. I'll leave that for future work, as this patch should be rolled out

@Wodann Wodann requested a review from baszalmstra June 12, 2020 08:48
@Wodann Wodann self-assigned this Jun 12, 2020
@Wodann Wodann added pri: high An issue resulting in complete or substantial loss of functionality, that can be circumvented type: fix Bug fix or report labels Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #221 into master will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         182      182           
  Lines       11903    11911    +8     
=======================================
+ Hits         9654     9661    +7     
- Misses       2249     2250    +1     
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/dispatch_table.rs 84.42% <83.33%> (-0.19%) ⬇️
crates/mun_codegen/src/test.rs 98.19% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d0839...6049096. Read the comment docs.

@Wodann Wodann force-pushed the fix/nested-private-fn branch from ecf0534 to 6049096 Compare June 13, 2020 14:34
@Wodann Wodann merged commit ec0c49d into mun-lang:master Jun 14, 2020
@Wodann Wodann deleted the fix/nested-private-fn branch August 7, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pri: high An issue resulting in complete or substantial loss of functionality, that can be circumvented type: fix Bug fix or report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants