fix: replaced overly complicated redirection rules with a simple hack#196
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom May 17, 2020
Merged
Conversation
31e0bdd to
81ec598
Compare
Wodann
approved these changes
May 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 163 163
Lines 11509 11509
=======================================
Hits 9546 9546
Misses 1963 1963 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the overly complex logic to make the documentation for v0.2 available under a subdirectory.
Instead of adding a
basetag to the documentation this PR adds some simple javascript to add a trailing slash to a url if the url doesnt end in.html. That should fix our relative path issues.It also removes the need for mdbook v0.4 so I reverted back to just downloading the binary. That should make our CI mucho faster.
As an added bonus I also added a github icon that links back this repo.
We also have to push these changes to
release/v0.2.Closes #195
Closes #190