improvement: return Rc<RefCell<Runtime>> from builder#153
Merged
Wodann merged 1 commit intomun-lang:masterfrom May 1, 2020
Merged
improvement: return Rc<RefCell<Runtime>> from builder#153Wodann merged 1 commit intomun-lang:masterfrom
Rc<RefCell<Runtime>> from builder#153Wodann merged 1 commit intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 160 160
Lines 11022 11028 +6
=======================================
+ Hits 9067 9072 +5
- Misses 1955 1956 +1
Continue to review full report at Codecov.
|
baszalmstra
approved these changes
May 1, 2020
Collaborator
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Nice ergonomic change
Wodann
changed the title
Rc<RefCell<Runtime>> from builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.