improvement: better literal support#122
Merged
baszalmstra merged 5 commits intomun-lang:masterfrom Apr 19, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 81.92% 82.72% +0.80%
==========================================
Files 141 147 +6
Lines 9055 9704 +649
==========================================
+ Hits 7418 8028 +610
- Misses 1637 1676 +39
Continue to review full report at Codecov.
|
4b9b86f to
d188cfd
Compare
Wodann
reviewed
Apr 9, 2020
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Once again, a very clean PR. Looking good!
069f7f8 to
940c908
Compare
4d03531 to
b0fd8ad
Compare
Collaborator
Author
|
The coverage diff on the last commits is pretty low because I included code from rustc_targets which does not contain tests. I'm also not using everything from the code but I added it nonetheless because I feel like it might benefit us in the future. |
b0fd8ad to
3b13886
Compare
Wodann
requested changes
Apr 19, 2020
3b13886 to
f8b47db
Compare
f8b47db to
2886280
Compare
Wodann
approved these changes
Apr 19, 2020
This was referenced Apr 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add support for:
100u8) (Add int and float literal type suffixes #121)Progress
0b10102)Out of scope
This PR does not implement literal type inferencing (#118).