TODOs part 2

[sstanculeanu]

Reasoning behind the pull request

• TODOs

Proposed changes

• TODOs:
  • // TODO: previously the number of missing reward txs was cleared in rewardTxsForBlock - check if this is still needed -> fixed, some late call to ReceivedTransaction could have put the channel in an invalid state
  • // TODO: previously the number of missing txs was cleared in scrForBlock - check if this is still needed -> fixed
  • // TODO: previously the number of missing txs was cleared in txsForCurrentBlock - check if this is still needed -> fixed
  • // TODO: evaluate disabling this entirely (for old flows) - the check is not triggered if async enabled but there are still some checks in the old flow -> fixed, guarded the only call with header v3 check
  • // TODO: analyze the requested headers in this func, after andromeda committed blocks are final -> fixed, no need to request the headers
  • // TODO: consider if tx count per metablock header is still needed -> fixed, not needed anymore, only used for metrics
  • // TODO: remove log if no longer needed for validation -> fixed, removed the log
  • // TODO: check again before saving the last executed result -> removed todo, already handled
  • // TODO check for overflow? -> removed, will happen in 500 years
  • // TODO: check if we need to pack also miniblock into smaller chunks -> removed, already throttled
  • // TODO analyze if this behaviour is ok. Even if the limit of txs per sender is exceeded, no tx is removed because the specific nonce is tracked. -> remvoed, enforcement is based on executed transactions, not tracked
  • // TODO modify when the function is updated -> fixed, updated ComputeCrossInfo to properly fetch num pending mbs
  • // todo: maybe sanitize, removing empty miniBlocks -> added a new method to remove the empty mbs

Testing procedure

• with feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

❌ Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.62%. Comparing base (53da698) to head (99e6591).

Files with missing lines	Patch %	Lines
process/block/metrics.go	66.66%	2 Missing and 1 partial ⚠️
process/coordinator/process.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           feat/testnet-fixes    #7884   +/-   ##
===================================================
  Coverage               77.62%   77.62%           
===================================================
  Files                     885      885           
  Lines                  125425   125451   +26     
===================================================
+ Hits                    97357    97387   +30     
+ Misses                  21585    21582    -3     
+ Partials                 6483     6482    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.