Subrounds timing by epoch#7881
Open
sstanculeanu wants to merge 3 commits into
Open
Conversation
sstanculeanu
added
the
ignore-for-release-notes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7881 +/- ##
======================================================
- Coverage 77.59% 77.58% -0.01%
======================================================
Files 884 884
Lines 125249 125273 +24
======================================================
+ Hits 97181 97188 +7
- Misses 21618 21634 +16
- Partials 6450 6451 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ssd04
reviewed
Jun 16, 2026
Contributor
There was a problem hiding this comment.
*optional: keep the constants for v1, and update the factory only for v2
Comment on lines
+113
to
+117
| SubroundStartStartTime = 0.0, | ||
| SubroundStartEndTime = 0.05, | ||
| SubroundBlockStartTime = 0.05, | ||
| SubroundBlockEndTime = 0.25, | ||
| SubroundSignatureStartTime = 0.25, |
Contributor
There was a problem hiding this comment.
*optional: remove Subround prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?