TODOs

[sstanculeanu]

Reasoning behind the pull request

• TODOs

Proposed changes

• TODOs fixed/removed:
  • // TODO add also max estimated block gas capacity + // TODO add also max estimated block gas capacity - used gas must be lower than this -> implemented, now uses the block capacity from economics data
  • // TODO: check if miniblocks and txs are set in a deterministic way (check if there are map iterations that can generate non-deterministic results) -> checked with @ssd04 , should be safe to remove todo
  • // todo: extract the epoch change proposal execution result here -> fixed, now all execution results are checked to find the proper epoch changed proposed header
  • // TODO: analyse error handling here -> checked with @ssd04 , this is old code and should be safe as before
  • // TODO use the right object, not a disabled one -> fixed, integrated the real transactions processor
  • // TODO use the right information below -> fixed, now data is fetched from chain handler
  • // TODO adjust this method if needed for Supernova -> removed todo, execution state should be correctly loaded at bootstrap from the headers
  • // TODO: the trigger would need to be changed upon commit of a block with the epoch start results -> removed todo, already handled
  • // TODO: set proper finalized header in outport -> checked with @BeniaminDrasovean , proper data is already set
  • // TODO: maybe rename this to reflect last execution results -> removed todo, not necessarily needed
  • // todo: check empty mini blocks vs nil. Same for block.Body.MiniBlocks -> removed todo, GetMiniBlockHeaderHandlers and GetMiniBlocks already normalizez empty slice to nil
  • // TODO: sanity check use the verify execution results method -> fixed, added call to VerifyHeaderExecutionResults
  • // TODO: this account adapter may be required to be changed as the roothash should be the last execution result roothash -> fixed, now trie is recreated everywhere

Testing procedure

• with feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

❌ Patch coverage is 61.72840% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.60%. Comparing base (53da698) to head (c9f95e6).

Files with missing lines	Patch %	Lines
factory/processing/processComponentsHandler.go	0.00%	7 Missing and 1 partial ⚠️
...external/transactionAPI/apiTransactionProcessor.go	37.50%	5 Missing ⚠️
...ess/estimator/executionResultInclusionEstimator.go	66.66%	4 Missing and 1 partial ⚠️
epochStart/metachain/economics.go	77.77%	3 Missing and 1 partial ⚠️
...ode/chainSimulator/components/processComponents.go	0.00%	3 Missing ⚠️
node/external/transactionAPI/check.go	50.00%	1 Missing and 1 partial ⚠️
process/block/baseProcess.go	75.00%	1 Missing and 1 partial ⚠️
process/block/shardblockProposal.go	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           feat/testnet-fixes    #7880      +/-   ##
======================================================
- Coverage               77.62%   77.60%   -0.02%     
======================================================
  Files                     885      885              
  Lines                  125425   125495      +70     
======================================================
+ Hits                    97357    97395      +38     
- Misses                  21585    21614      +29     
- Partials                 6483     6486       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[miiu96]

maybe you can extract this code in a new function ?