extra checks shard data proposal#7877
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7877 +/- ##
===================================================
Coverage 77.61% 77.62%
===================================================
Files 885 885
Lines 125414 125425 +11
===================================================
+ Hits 97345 97359 +14
+ Misses 21587 21585 -2
+ Partials 6482 6481 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ssd04
reviewed
Jun 11, 2026
Comment on lines
+153
to
+162
| for _, sd := range shardDataProposed { | ||
| if sd.GetShardID() >= coordinator.NumberOfShards() && sd.GetShardID() != core.MetachainShardId { | ||
| return process.ErrInvalidShardId | ||
| } | ||
| } | ||
|
|
||
| shardDataHashes := make([][]byte, len(shardDataProposed)) | ||
| for i, sd := range shardDataProposed { | ||
| shardDataHashes[i] = sd.GetHeaderHash() | ||
| } |
Contributor
There was a problem hiding this comment.
collect shardDataHashes in the first loop to avoid iterating twice?
| assert.Equal(t, process.ErrDuplicatedHashInBlock, err) | ||
| } | ||
|
|
||
| // ------- checkMetaShardDataProposal |
sstanculeanu
approved these changes
Jun 19, 2026
AdoAdoAdo
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?