Skip to content

Update chain handler#7867

Merged
ssd04 merged 9 commits into
feat/testnet-fixesfrom
update-chain-handler
Jun 18, 2026
Merged

Update chain handler#7867
ssd04 merged 9 commits into
feat/testnet-fixesfrom
update-chain-handler

Conversation

@ssd04

@ssd04 ssd04 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

  • There were multiple operations to set last execution result context in blockchain handler
  • Updated operations to have SetLastExecutionInfo to have all execution result related calls atomically

Testing procedure

  • Standard full system test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Jun 2, 2026
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.61905% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.54%. Comparing base (4d94bfb) to head (f4d7923).

Files with missing lines Patch % Lines
dataRetriever/blockchain/baseBlockchain.go 57.89% 7 Missing and 1 partial ⚠️
dataRetriever/blockchain/blockchain.go 0.00% 5 Missing ⚠️
dataRetriever/blockchain/metachain.go 0.00% 5 Missing ⚠️
...hainSimulator/components/testOnlyProcessingNode.go 0.00% 3 Missing ⚠️
process/block/baseProcess.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/testnet-fixes    #7867      +/-   ##
======================================================
- Coverage               77.57%   77.54%   -0.03%     
======================================================
  Files                     884      884              
  Lines                  125210   125218       +8     
======================================================
- Hits                    97130    97106      -24     
- Misses                  21628    21654      +26     
- Partials                 6452     6458       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sstanculeanu
sstanculeanu previously approved these changes Jun 2, 2026
sstanculeanu
sstanculeanu previously approved these changes Jun 18, 2026
header data.HeaderHandler,
result data.BaseExecutionResultHandler,
) {
bbc.mut.Lock()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should add nil check for header and execution results ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread go.sum Outdated
github.com/multiversx/mx-chain-communication-go v1.3.3-0.20260608072730-982186a1ad78/go.mod h1:gDVWn6zUW6aCN1YOm/FbbT5MUmhgn/L1Rmpl8EoH3Yg=
github.com/multiversx/mx-chain-core-go v1.5.1-0.20260608073155-f1f550c8a612 h1:Hol8/gBD3d84kIuVsss+1Zx+sUIOpshU/wHC1d2DFVI=
github.com/multiversx/mx-chain-core-go v1.5.1-0.20260608073155-f1f550c8a612/go.mod h1:IO+vspNan+gT0WOHnJ95uvWygiziHZvfXpff6KnxV7g=
github.com/multiversx/mx-chain-core-go v1.5.1-0.20260422103502-8282c53621fc h1:/Q2xPi9/AkIl7mzzg/gY2tC4YM91MD8YWKhi5QJMCG0=

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run go mod tidy

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ssd04 ssd04 merged commit c1086aa into feat/testnet-fixes Jun 18, 2026
9 of 11 checks passed
@ssd04 ssd04 deleted the update-chain-handler branch June 18, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants