Update chain handler#7867
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7867 +/- ##
======================================================
- Coverage 77.57% 77.54% -0.03%
======================================================
Files 884 884
Lines 125210 125218 +8
======================================================
- Hits 97130 97106 -24
- Misses 21628 21654 +26
- Partials 6452 6458 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sstanculeanu
previously approved these changes
Jun 2, 2026
sstanculeanu
previously approved these changes
Jun 18, 2026
miiu96
reviewed
Jun 18, 2026
| header data.HeaderHandler, | ||
| result data.BaseExecutionResultHandler, | ||
| ) { | ||
| bbc.mut.Lock() |
Contributor
There was a problem hiding this comment.
maybe you should add nil check for header and execution results ?
| github.com/multiversx/mx-chain-communication-go v1.3.3-0.20260608072730-982186a1ad78/go.mod h1:gDVWn6zUW6aCN1YOm/FbbT5MUmhgn/L1Rmpl8EoH3Yg= | ||
| github.com/multiversx/mx-chain-core-go v1.5.1-0.20260608073155-f1f550c8a612 h1:Hol8/gBD3d84kIuVsss+1Zx+sUIOpshU/wHC1d2DFVI= | ||
| github.com/multiversx/mx-chain-core-go v1.5.1-0.20260608073155-f1f550c8a612/go.mod h1:IO+vspNan+gT0WOHnJ95uvWygiziHZvfXpff6KnxV7g= | ||
| github.com/multiversx/mx-chain-core-go v1.5.1-0.20260422103502-8282c53621fc h1:/Q2xPi9/AkIl7mzzg/gY2tC4YM91MD8YWKhi5QJMCG0= |
miiu96
approved these changes
Jun 18, 2026
sstanculeanu
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
SetLastExecutionInfoto have all execution result related calls atomicallyTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?