Storage save optimizations#7864
Draft
ssd04 wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7864 +/- ##
======================================================
- Coverage 77.53% 77.52% -0.01%
======================================================
Files 883 883
Lines 124506 124519 +13
======================================================
Hits 96536 96536
- Misses 21558 21565 +7
- Partials 6412 6418 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssd04
commented
May 29, 2026
| } | ||
|
|
||
| if metaHeader.IsStartOfEpochBlock() { | ||
| log.LogIfError(mp.epochStartTrigger.RevertStateToBlock(metaHeader)) |
Contributor
Author
There was a problem hiding this comment.
calling RevertStateToBlock might not fully revert SetProcessed, tbd
AdoAdoAdo
reviewed
Jun 19, 2026
| _ = mp.blockChain.SetCurrentBlockHeader(prevBlockHeader) | ||
| mp.blockChain.SetCurrentBlockHeaderHash(prevBlockHeaderHash) | ||
|
|
||
| mp.revertEpochStartTrigger(headerHandler) |
Contributor
There was a problem hiding this comment.
the RevertStateToBlock which is called inside revertEpochStartTrigger was supposed to be called with the previous header not the header being reverted.
Now we do need the current header as well (for the new flag) but I don't think the new method was fully adapted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?