recreate interceptors on bootstrap by AdoAdoAdo · Pull Request #7861 · multiversx/mx-chain-go

AdoAdoAdo · 2026-05-28T11:46:47Z

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copilot

Pull request overview

This PR fixes a bootstrap correctness issue where network components (resolvers, request handler, interceptors/syncers) were created against the bootstrap-time shard coordinator and never rebuilt after requestAndProcessing() reassigns e.shardCoordinator to the node's resolved destination shard. The fix introduces rebuildNetworkComponentsForShard(), which tears down the existing main/full-archive interceptor containers and resolvers container (unregistering their topics on both messengers) and recreates them with the resolved coordinator before the consensus topic is created. The deferred close in Bootstrap() is made nil-safe to avoid double-close after teardown.

Changes:

Add resolversContainer field and rebuildNetworkComponentsForShard/tearDownStaleNetworkComponents helpers; invoke the rebuild after the shard coordinator is reassigned in requestAndProcessing().
Make the deferred interceptor-container Close() in Bootstrap() nil-safe.
Add test-only accessors and three unit tests covering no-op, rewire, and error propagation behaviors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
epochStart/bootstrap/process.go	Adds rebuild/teardown helpers, stores resolvers container, hooks rebuild into `requestAndProcessing()`, makes deferred close nil-safe.
epochStart/bootstrap/process_test.go	Adds tests for the new rebuild behavior (no-op, rewire, error propagation) and helpers to collect topics.
epochStart/bootstrap/export_test.go	Exports the new method and internal containers/request handler for tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-05-28T11:58:23Z

Codecov Report

❌ Patch coverage is 71.42857% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.61%. Comparing base (adf0114) to head (48c6755).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
epochStart/bootstrap/process.go	58.18%	16 Missing and 7 partials ⚠️
epochStart/bootstrap/storageProcess.go	48.88%	19 Missing and 4 partials ⚠️
process/sync/metablock.go	76.78%	9 Missing and 4 partials ⚠️
epochStart/shardchain/trigger.go	95.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7861      +/-   ##
==========================================
- Coverage   76.62%   76.61%   -0.01%     
==========================================
  Files         814      814              
  Lines      110955   111153     +198     
==========================================
+ Hits        85019    85165     +146     
- Misses      20142    20180      +38     
- Partials     5794     5808      +14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

…eptors-on-storage more bootstrap optimizations

github-actions · 2026-05-28T15:41:13Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 87c1564052899fdad4f0eb87c9c6f338ffc2232c
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_MAY_28__14_40_12
PYTEST_EXIT_CODE: 1

unregister all processors on tear down

github-actions · 2026-06-02T11:01:41Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: f0c8c15dc75e48fb75a1609c34c57966940bab29
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_JUNE_02__10_05_15
PYTEST_EXIT_CODE: 1

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

…-on-msg-reverse-order

github-actions · 2026-06-09T15:16:26Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 98c228b964c5a3763ce48cbbbeb24f3b9963b9b8
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_JUNE_09__14_14_57
PYTEST_EXIT_CODE: 1

…e-order Fix transition on msg reverse order

github-actions · 2026-06-10T09:37:47Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 2ea25abd4b7a2e74975ea30c6ecdd3e87e794e31
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_JUNE_10__08_35_01
PYTEST_EXIT_CODE: 1

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

epochStart/shardchain/triggerRegistry_test.go:26

In cloneTrigger(), metaEpoch is being copied from t.epoch instead of t.metaEpoch. Since the new tests rely on cloneTrigger() for equality checks, this can mask real state mismatches and produce false positives.

	rt.epoch = t.epoch
	rt.metaEpoch = t.epoch
	rt.currentRoundIndex = t.currentRoundIndex

github-actions · 2026-06-10T12:07:46Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 1dfe15095866cfdb829fbcf5e1ee39b136d1c4d5
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_JUNE_10__11_03_19
PYTEST_EXIT_CODE: 1

github-actions · 2026-06-10T12:29:35Z

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 48c6755fd49ae4bc245ffada038a8c8921dcc140
Current Branch: start-in-epoch-reload-interceptors
mx-chain-go Target Branch: master
mx-chain-simulator-go Target Branch: main
mx-chain-testing-suite Target Branch: main
mx-chain-simulator-go Commit Hash: 771e2f48f7a5d3cc83fc880558e5efe7befd7ee8

🚀 Environment Variables:

TIMESTAMP: 2026_JUNE_10__11_21_05
PYTEST_EXIT_CODE: 1

recreate interceptors on bootstrap

1ba932c

AdoAdoAdo requested a review from Copilot May 28, 2026 11:50

Copilot started reviewing on behalf of AdoAdoAdo May 28, 2026 11:50 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread epochStart/bootstrap/process.go Outdated

fixes after review

05f1e32

AdoAdoAdo requested a review from Copilot May 28, 2026 12:15

Copilot started reviewing on behalf of AdoAdoAdo May 28, 2026 12:16 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

sstanculeanu previously approved these changes May 28, 2026

View reviewed changes

ssd04 previously approved these changes May 28, 2026

View reviewed changes

raduchis and others added 3 commits May 28, 2026 16:52

more bootstrap optimizations

96b9d52

add nil checks

0436b9d

Merge pull request #7862 from multiversx/start-in-epoch-reload-interc…

87c1564

…eptors-on-storage more bootstrap optimizations

AdoAdoAdo dismissed stale reviews from ssd04 and sstanculeanu via 87c1564 May 28, 2026 14:39

sstanculeanu previously approved these changes May 28, 2026

View reviewed changes

sstanculeanu and others added 2 commits May 29, 2026 15:00

unregister all processors on tear down

94ed12d

Merge pull request #7865 from multiversx/completely-unregister

f0c8c15

unregister all processors on tear down

sstanculeanu dismissed their stale review via f0c8c15 June 2, 2026 10:04

AdoAdoAdo marked this pull request as ready for review June 9, 2026 08:09

AdoAdoAdo requested a review from Copilot June 9, 2026 08:09

Copilot started reviewing on behalf of AdoAdoAdo June 9, 2026 08:09 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread epochStart/bootstrap/process.go Outdated

Comment thread epochStart/bootstrap/storageProcess.go

AdoAdoAdo added 4 commits June 9, 2026 13:23

port request SOE meta watchdog

18d7927

remove Andromeda request gate

55c16e0

add meta sync watchdog for epoch start block

682e1ff

Merge branch 'start-in-epoch-reload-interceptors' into fix-transition…

d496a32

…-on-msg-reverse-order

fix after review

98c228b

fix after review

2064a96

sstanculeanu previously approved these changes Jun 10, 2026

View reviewed changes

Merge pull request #7876 from multiversx/fix-transition-on-msg-revers…

2ea25ab

…e-order Fix transition on msg reverse order

AdoAdoAdo dismissed sstanculeanu’s stale review via 2ea25ab June 10, 2026 08:34

sstanculeanu previously approved these changes Jun 10, 2026

View reviewed changes

ssd04 previously approved these changes Jun 10, 2026

View reviewed changes

fix tests

1dfe150

AdoAdoAdo dismissed stale reviews from ssd04 and sstanculeanu via 1dfe150 June 10, 2026 11:02

sstanculeanu previously approved these changes Jun 10, 2026

View reviewed changes

AdoAdoAdo requested a review from Copilot June 10, 2026 11:04

Copilot started reviewing on behalf of AdoAdoAdo June 10, 2026 11:04 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread epochStart/shardchain/triggerRegistry_test.go Outdated

fix lock

48c6755

AdoAdoAdo dismissed sstanculeanu’s stale review via 48c6755 June 10, 2026 11:17

sstanculeanu approved these changes Jun 10, 2026

View reviewed changes

ssd04 approved these changes Jun 10, 2026

View reviewed changes

raduchis approved these changes Jun 10, 2026

View reviewed changes

AdoAdoAdo merged commit ba99de8 into master Jun 10, 2026
11 of 14 checks passed

AdoAdoAdo deleted the start-in-epoch-reload-interceptors branch June 10, 2026 12:09

Conversation

AdoAdoAdo commented May 28, 2026

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented May 28, 2026 •

edited

Loading